Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Calculate Gradient function does not take in the use_gpu flag #18

Closed
vinayshekharcmu opened this issue Nov 7, 2019 · 2 comments · Fixed by #25
Closed

Calculate Gradient function does not take in the use_gpu flag #18

vinayshekharcmu opened this issue Nov 7, 2019 · 2 comments · Fixed by #25
Labels
bug Something isn't working

Comments

@vinayshekharcmu
Copy link

Calculate Gradient function does not take in the use_gpu flag. Although the flag is taken in the visualize function, it is not used in the calculate_graidents function

@vinayshekharcmu vinayshekharcmu added the bug Something isn't working label Nov 7, 2019
@vinayshekharcmu
Copy link
Author

I have a PR ready. But don't have permission to push to the repo.

@MisaOgura
Copy link
Owner

MisaOgura commented Nov 11, 2019

Hi @vinayshekharcmu,

The calculate_gradient (for the Backprop class) does take use_gpu flag.

However, I spotted that visualize function does not pass that flag down to the underlying calculate_gradient function.

Will release this fix very soon.

Many thanks,
Misa

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants