Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redundant directory creation in ephemeral-btrfs.nix #29

Open
breezeight opened this issue Jan 5, 2024 · 0 comments
Open

Redundant directory creation in ephemeral-btrfs.nix #29

breezeight opened this issue Jan 5, 2024 · 0 comments

Comments

@breezeight
Copy link

I was looking at the ephemeral-btrfs module. I see you ensure needed directories exists:

echo "Creating needed directories"
mkdir -p "$MNTPOINT"/persist/var/{log,lib/{nixos,systemd}}

But as far I understand the impermanence module included in optin-persistence.nix should

environment.persistence = {
"/persist" = {
directories = [
"/var/lib/systemd"
"/var/lib/nixos"
"/var/log"
"/srv"
];
};
};

Does it make sense to ephemeral-btrfs.nix removing the above lines?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant