Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Request: Custom actions on keybinds #685

Open
dali99 opened this issue Jun 6, 2022 · 3 comments
Open

Feature Request: Custom actions on keybinds #685

dali99 opened this issue Jun 6, 2022 · 3 comments
Labels
enhancement investigate Requires investigation

Comments

@dali99
Copy link

dali99 commented Jun 6, 2022

It'd be nice to be able to bind custom keywords to binds
The idea is to use it with git-revise, which adds index and cut as available actions

I've hardcoded support for those in https://github.com/dali99/git-interactive-rebase-tool but it'd be better if there was a Custom(String) action or something you could manually bind

Architecturally this seems a little complicated though

@MitMaro
Copy link
Owner

MitMaro commented Jun 6, 2022

That's an interesting idea, though I agree that was the current architecture it's a bit complicated. Let me think about to integrate custom actions could work.

I do like the idea of allowing custom actions in some form.

@MitMaro MitMaro added enhancement investigate Requires investigation labels Jun 7, 2022
@forivall
Copy link

forivall commented Oct 7, 2022

Since I'll be detecting files to tackle #739, so the easier solution might just be to explicitly support git-revise's actions when using git-revise (as it's a tool I also use 😅). It exposes a single ".git/revise.<mktemp-randomness>/git-revise-todo" file, so the same technique can be used to detect it.

@MitMaro
Copy link
Owner

MitMaro commented Oct 7, 2022

I can get behind that idea, of only allowing those options in the context of git-revise. Essentially, providing first-class support for git-revise when the git revise file exists, and hiding support when revise is not detected.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement investigate Requires investigation
Projects
None yet
Development

No branches or pull requests

3 participants