Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The router has stray onhashchange-related code #2778

Open
pygy opened this issue May 30, 2022 · 0 comments
Open

The router has stray onhashchange-related code #2778

pygy opened this issue May 30, 2022 · 0 comments
Assignees
@dead-claudia
Labels
Area: Core For anything dealing with Mithril core itself Type: Bug For bugs and any other unexpected breakage

Comments

@pygy
Copy link
Member

pygy commented May 30, 2022

m.route.set() doesn't set the hash directly anymore, meaning that non-pushState-based routing doesn't work anymore.

There are however some onhashchange-related code in the router.

Mithril.js version:

v2.2.2
@pygy pygy added the Type: Bug For bugs and any other unexpected breakage label May 30, 2022
@dead-claudia dead-claudia added the Area: Core For anything dealing with Mithril core itself label Sep 2, 2024
@dead-claudia dead-claudia mentioned this issue Oct 13, 2024
Open
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dead-claudia dead-claudia

Labels
Area: Core For anything dealing with Mithril core itself Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pygy @dead-claudia