Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Error with by using fairness graph (plotly 6.0.0 compatibility) #573

Closed
lionelkusch opened this issue Feb 12, 2025 · 4 comments
Closed

Error with by using fairness graph (plotly 6.0.0 compatibility) #573

lionelkusch opened this issue Feb 12, 2025 · 4 comments
Labels
invalid ❕ This doesn't seem right, potential bug Python 🐍 Related to Python short term ⏰ TODO short term

Comments

@lionelkusch
Copy link
Contributor

In version 6.0.0 of plotly, titlefont parameter of layout doesn't exist anymore.
This makes an error for fainess graph. The lowing ligne should be fixed by replacing titlefont by title_font`

I allow me to suggest that you modify your setup configuration by adding to the following line ',<6.0.

'plotly>=5.1.0',

@lionelkusch lionelkusch changed the title Error with by using fairness with Error with by using fairness graph Feb 12, 2025
@hbaniecki
Copy link
Member

Hi @lionelkusch, thanks for catching this one! Would you consider making a pull request to fix this issue?

@hbaniecki hbaniecki added Python 🐍 Related to Python invalid ❕ This doesn't seem right, potential bug short term ⏰ TODO short term labels Feb 12, 2025
@lionelkusch
Copy link
Contributor Author

Do you want a pull request for fixing the setup for compatibility? Or a pull request for fixing the compatibility with plotly 6.0.0?

@hbaniecki
Copy link
Member

Right, I see that plotly 6.0 has just been released, and perhaps there are more compatibility issues like the one you found, so I prefer to restrict plotly < 6.0 as you suggested (for now).

@hbaniecki hbaniecki changed the title Error with by using fairness graph Error with by using fairness graph (plotly 6.0.0 compatibility) Feb 12, 2025
@hbaniecki
Copy link
Member

The fix should be now available on PyPI https://pypi.org/project/dalex/1.7.2/

I guess with such breaking changes, it's either <6.0.0 or >=6.0.0, so we will need to wait for the new version to become more popular before migratingdalex code.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
invalid ❕ This doesn't seem right, potential bug Python 🐍 Related to Python short term ⏰ TODO short term
Projects
None yet
Development

No branches or pull requests

2 participants