Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug: Syntax error appears instead of off beside toggle switches #178

Closed
Poopooracoocoo opened this issue Nov 3, 2020 · 24 comments · Fixed by #582
Closed

Bug: Syntax error appears instead of off beside toggle switches #178

Poopooracoocoo opened this issue Nov 3, 2020 · 24 comments · Fixed by #582
Assignees
@Samuel12321
Labels
Bug Something isn't working High Priority Translation

Comments

@Poopooracoocoo
Copy link
Contributor

ModernFlyouts version: 0.8.0.1
Windows 10 version: 20H2
Windows 10 language: English (Australia)
@Poopooracoocoo Poopooracoocoo added the Bug Something isn't working label Nov 3, 2020
@Poopooracoocoo Poopooracoocoo changed the title Bug: Syntax error appears instead of off beside toggle switches when flyout modules are off Bug: Syntax error appears instead of off beside toggle switches Nov 3, 2020
@ShankarBUS
Copy link
Member

@Samuel12321, FYI

@ShankarBUS
Copy link
Member

@Poopooracoocoo
¿uɐılɐɹʇsn∀ uɐ ǝɹɐ no⅄

@Samuel12321
Copy link
Member

Samuel12321 commented Nov 4, 2020 •
edited
Loading

@ShankarBUS why is this closed. Have you fixed it?

@ShankarBUS
Copy link
Member

Sorry!

@ShankarBUS ShankarBUS reopened this Nov 4, 2020
@ShankarBUS
Copy link
Member

@Samuel12321,

This must have been fixed by now, isn't it?

@Samuel12321
Copy link
Member

unfortunately no, still a problem

@Samuel12321 Samuel12321 mentioned this issue Dec 21, 2020
Closed
@Samuel12321
Copy link
Member

Tentatively adding to the 0.9 release as this is a frequent bug.

@Renzo904
Copy link
Contributor

This is a "translation error", I mean, seems like the Australian english is using the "en-GB" strings, and that strings have "Syntax error" as translation of "Off", tomorrow (12-11 hours later😂) Im going to made a PR if nobody does haha

@Samuel12321
Copy link
Member

oh, i didn't notice that.
I only checked en-NZ when i checked to see whether it could just be a translation error.😉😂

@Samuel12321
Copy link
Member

will include a fix in my next PR

@Renzo904
Copy link
Contributor

Renzo904 commented Dec 21, 2020 •
edited
Loading

Haha me too😂😂, but then I wanted to check everything
No problem👍

@Samuel12321
Copy link
Member

9e8bfb4

@prakharb5 prakharb5 added the Fixed Has been fixed. label Jan 9, 2021
@prakharb5 prakharb5 assigned Samuel12321 and unassigned ShankarBUS Jan 9, 2021
@prakharb5 prakharb5 mentioned this issue Jan 13, 2021
Closed
@Poopooracoocoo
Copy link
Contributor Author

Still seeing this issue with version 0.9.0.0 from MS Store and am a beta tester :) @Samuel12321

@Samuel12321
Copy link
Member

Will look into this.

@prakharb5 prakharb5 reopened this Jan 31, 2021
@prakharb5 prakharb5 removed the Fixed Has been fixed. label Jan 31, 2021
@prakharb5 prakharb5 added this to the 0.9 milestone Jan 31, 2021
@Samuel12321
Copy link
Member

@Poopooracoocoo does this still occur in 0.9.1?
with the exception of the start with windows toggle off position, which has been fixed for 0.9.2 they should all be resolved.

@Poopooracoocoo
Copy link
Contributor Author

@Samuel12321 Still occurring in 0.9.1 :(

@Samuel12321
Copy link
Member

@Poopooracoocoo can you send a screenshot + info about your setup - set language, os version...

@Poopooracoocoo
Copy link
Contributor Author

@Samuel12321
info:
ModernFlyouts version 0.9.1
Windows 10 20H2
English (Australia)

screenie:
image

@Samuel12321 Samuel12321 removed this from the 0.9 milestone Mar 15, 2021
@Samuel12321 Samuel12321 reopened this Mar 15, 2021
@prakharb5
Copy link
Member

Aw man. Be fixed already!

@baloo32
Copy link

baloo32 commented Mar 18, 2021

Just to add to this:

Modern Flyouts v 0.9.1.0 (just updated)
Win 10 Pro 20H2 (Build19042.868)
English (United Kingdom) [EN-gb?]

image

image

image

image

image

etc. etc.

@ghost
Copy link

ghost commented Apr 22, 2021

In ModernFlyouts.en-GB.xlf, there is a "syntax error" as a translation of "off" in all branches.

<trans-unit id="Settings.Off" translate="yes" xml:space="preserve">
  <source>Off</source>
  <target state="needs-review-translation" state-qualifier="tm-suggestion">Syntax error</target>
</trans-unit>

@Samuel12321
Copy link
Member

Yes it keeps reoccurring, will try to fix it again.

@Samuel12321 Samuel12321 linked a pull request Apr 22, 2021 that will close this issue
Dev merge for 0.9.3 #582
Merged
@Samuel12321
Copy link
Member

Hopefully fixed this time for 0.9.3

@Poopooracoocoo
Copy link
Contributor Author

Can confirm that it's fixed! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Samuel12321 Samuel12321

Labels
Bug Something isn't working High Priority Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev merge for 0.9.3 ModernFlyouts-Community/ModernFlyouts
6 participants
@baloo32 @Samuel12321 @Poopooracoocoo @prakharb5 @Renzo904 @ShankarBUS