traitor backstories goes NTOS death

[MonkestationIssueBot]

Reporting client info: Client Information:
BYOND:515.1641
Key:thelobsterr

Round ID:

8727

Testmerges:

• [DNM] Aneri except I redid the branch again
• [Bounty] Graytide Sectorwide
• [s] some internal admin tool improvements
• AWAKEN THE DRAGON!
• Removes TWitch from normal rounds, and blacklists key chems from stra
• [PORT] Ports the port of traitor backstories from yogstation from beestation
• Replaced Blueshield's mantis blades with shield blades + mantis blade changes
• [DNM]Oozling qol fixes
• Fixes 4648
• [BALANCE] Nerf the Paco's magazine size
• Crew hud for ghosts and silicons
• Syndicate Depot and Various Unrelated Map Fixes that Pooba Asked For
• [PORT] Fancy boxed messages!
• Some ghost roles can now use preferences!

Reproduction:

picking a faction made it bluescreen me, it was indepedent

[TheLobsterrr]

minor update, every other faction i chose also bluescreened me

[DexeeXI]

non descriptive issue report.

@TheLobsterrr is this regarding being a contractor and picking it?

[TheLobsterrr]

yeah, i was a drifting contractor and when i tried to select any faction it bluescreened

[DexeeXI]

#4481 specifically is breaking.

[DexeeXI]

@TheLobsterrr I need more info. Was this a situation of either:

a) spawned as a traitor, and picked the contractor kit
b) spawned as a drifting contractor in space and picked it

[TheLobsterrr]

this was being spawned as a drifting contractor in space, when the menu asked me to pick a faction it bluescreened me whenever i tried to select any faction like independent or gorlex, and continued to bluescreen whenever i reopened the menu to select again

[DexeeXI]

Okay. The merge is not on TM any longer, so I am unable to reproduce this at the moment.

[cowbot92]

This should be resolved as of my latest push to the PR, looks like it wasn't setting up backstories because the proc used to give objectives was different than traitors. If it continues to happen let me know.