Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inconsistent arg handling #31

Open
tomdonaldson opened this issue Aug 11, 2020 · 1 comment
Open

Inconsistent arg handling #31

tomdonaldson opened this issue Aug 11, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tomdonaldson
Copy link
Contributor

In running

sm_run_all input

gets the error message

error: --result_dir is required

If this is required, it should be positional and the help shouldn't list
it as optional.

Then running

sm_run_all input -r result

it ran through them all but they all errored. The cone searches
wanted me to give the cone information:

     sm_query: error: Either --num-cones or --cone_file must be present
        to specify what values go into the service file templates.

and the TAP queries gave the same error message in spite of not
being cones.

@tomdonaldson tomdonaldson added the enhancement New feature or request label Aug 11, 2020
@tomdonaldson
Copy link
Contributor Author

Inconsistent handling of args and defaults is one negative about doing the run all feature in bash as opposed to Python. Most of the args are passed through, but it's hard to have maintainably consistent defaults that way. It would be an easy Python script to replace sm_run_all, but I've been leery because my initial exposure to Python handling child processes and their output streams had many gotchas. Even more so I'm not comfortably trusting these measurements in a multithreaded environment.

Until this issue is addressed. these constraints hold:

  • sm_run_all requires a --result_dir value even though it defaults to "result" for sm_query.
  • Either --num-cones or --cone_file must be present for both cone and TAP searches since that's what's specifying the RA, DEC and Radius. Ideally those missing params would be detected by sm_run_all.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant