Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Condense the first two arguments of the linear solver so that we don't need to make a copy #492

Closed
Tracked by #211
K20shores opened this issue May 6, 2024 · 0 comments · Fixed by #585
Closed
Tracked by #211
Assignees

Comments

@K20shores
Copy link
Collaborator

K20shores commented May 6, 2024

The first and second argument of the linear solver are the same and we always have to make a copy. In #485 the forcing vector was just passed in for both arguments and things worked. That means we can remove one of the arguments and prevent a copy.

Acceptance

  • There is only one matrix passed into linear solve
  • The copy of the matrix is removed from the CPU and GPU versions of Rosenbrock
@K20shores K20shores added this to the Tech Debt milestone May 6, 2024
@K20shores K20shores self-assigned this Jun 26, 2024
@K20shores K20shores linked a pull request Jun 28, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants