Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check if resetting the L and U matrices before solving with Rosenbrock is needed #587

Closed
Tracked by #211
mattldawson opened this issue Jun 28, 2024 · 1 comment
Closed
Tracked by #211
Assignees
Labels
question Further information is requested

Comments

@mattldawson
Copy link
Collaborator

Currently the lower and upper matrices on the State are reset to zero at the beginning of the Rosenbrock solve, but this shouldn't actually be necessary. It was likely just causing an error before the normalized error function was set to properly work with vectorizable matrices where the number of grid cells was not even divisible by the vector dimension. See if this can be removed now.

Acceptance Criteria

  • The reseting of the lower and upper matrices at the beginning of the solve is removed or an explanation of why it is necessary is included as a comment in the code
@mattldawson mattldawson added the question Further information is requested label Jun 28, 2024
@mattldawson mattldawson added this to the MICM, TUV-x in CAM-SIMA milestone Jun 28, 2024
@K20shores
Copy link
Collaborator

Added in this PR (kyle can't remember why, but was doing lots of work in the performance repo at the time and some repeated calls were causing issues, maybe in the benchmarking)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
question Further information is requested
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants