Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add typescript to dev dependencies #4

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Jun 26, 2022

Currently, the "typescript" module is not part of the development dependencies, so building with tsc fails unless one has typescript installed globally (should not be assumed IMHO).

When merged in, the "typescript" modules will be part of the build chain's development dependencies.

@boyum boyum force-pushed the otacke/add-typescript branch from 64b8878 to 5b3be74 Compare June 29, 2022 07:05
@boyum
Copy link
Contributor

boyum commented Jun 29, 2022

🎉

@boyum boyum merged commit fbb6595 into NDLANO:main Jun 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants