Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Browse Data button again and rename Search Database to Search Structure #1073

Closed
tilfischer opened this issue Jan 31, 2024 · 0 comments · Fixed by #1079
Closed

Add Browse Data button again and rename Search Database to Search Structure #1073

tilfischer opened this issue Jan 31, 2024 · 0 comments · Fixed by #1079
Assignees
Labels

Comments

@tilfischer
Copy link
Member

Dear all,

Is your enhancement request related to a problem? Please describe.
I noticed today that you have implemented structure search via SMILES. Great!

Screenshot 2024-01-31 110741

However, the "Browse Data" button is gone. I could submit an empty search query and arrive at https://nmrxiv.org/compounds/?query=&type=exact , which is headlined with "Browse Compounds". However, this is not intuitive to many users.

Compounds are molecular compound, ionic compounds, intermetallic compounds as well as chemical complexes. If it is termed "Compounds" this would exclude a) Elements and b) Mixtures. Strictly speaking all liquid state NMR spectra show mixtures, as there is something or many thing dissolved and there is a solvent for that. We could start arguing now to call this Chemical Substance, Molecular Entity or Chemical Entity. My suggestion would be to call this "Data", as it was previously termed.

I also would not come up with the term "Database" on the welcome page. Sure, there is a database system in the backend.

Describe the solution you'd like
Add the "Browse Data" button again. Rename "Search Database" to "Structure Search" as it is called here or "Seach Structure"

Best,
Tillmann

@tilfischer tilfischer added the enhancement greater code or enhancement of existing feature label Jan 31, 2024
@CS76 CS76 self-assigned this Feb 2, 2024
@CS76 CS76 added testing and removed enhancement greater code or enhancement of existing feature labels Feb 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants