Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Command line interface does not update RunPeriods between runs. #5897

Closed
tsnouidui opened this issue Oct 4, 2016 · 7 comments · Fixed by #8008
Closed

Command line interface does not update RunPeriods between runs. #5897

tsnouidui opened this issue Oct 4, 2016 · 7 comments · Fixed by #8008
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus SeverityHigh This defect is high severity, generally indicating a hard crash without a workaround

Comments

@tsnouidui
Copy link

@Myoldmopar @nealkruis

I found the following issue (?) when trying to use the command line interface of E+.
I am using EnergyPlus version 8.5 on Windows 10 64 bit.

I have an IDF named SmOffPSZ.idf which I ran using the command line below:

energyplus -w C:/EnergyPlusV8-5-0/WeatherData/USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw -p SmOffPSZ -s C -x -m -r SmOffPSZ.idf

The run was successful.

I changed the RunPeriod in the IDF and try to re-run it using the same command.
Surprisingly, I noticed that the IDF was run using the previous RunPeriod.

I had to manually delete the files generated from previous run for the CLI to use the correct RunPeriod.
Is this the expected behavior?

Thanks!

Please rename the file from jpg to IDF to reproduce.

smoffpsz

@tsnouidui tsnouidui added the Defect Includes code to repair a defect in EnergyPlus label Oct 4, 2016
@tsnouidui tsnouidui added this to the EnergyPlus 8.7.0 milestone Oct 4, 2016
@nealkruis
Copy link
Member

@tsnouidui are you sure you're editing the correct file? both ExpandObjects (-x) and EPMacro (-m) will create temporary IDFs that will be overwritten on subsequent runs.

@tsnouidui
Copy link
Author

@nealkruis Did you try on Windows 10 to see if you can reproduce?

@nealkruis
Copy link
Member

The rename function on Windows does not allow files to be overwritten like it does for other operating systems. There is a bit on how to better handle this here.

We should also do a better job of trapping these kind of failures. Currently, they are pretty quiet.

@JasonGlazer
Copy link
Contributor

JasonGlazer commented Jun 16, 2017

I stumbled across another instance of this problem related to using the -x expandobjects option. Ran a file (LBuilding-G090.idf) on Windows within Visual Studio using command line options.

--output-prefix LBuilding-G090 --readvars -D -x --idd Energy+.idd --weather USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw LBuilding-G090.idf

The file contained HVACTemplates so the expidf file was created. Edited the file to add "Output:Diagnostics, DisplayExtraWarnings;" and reran the file. The err file showed no additional messages. When I checked in debugger, it did not even find an OutputDiagnostics object. Deleted the expidf file and reran the file and the extra warning messages were there. It behaved like the expidf file was not being overwritten.

I confirmed that when using the command line with HVACTemplates, changes made to the IDF file after the first time EnergyPlus runs ExpandObjects are not read by EnergyPlus. The expidf file needs to be deleted prior to ExpandObjects running.

@JasonGlazer JasonGlazer added the SeverityHigh This defect is high severity, generally indicating a hard crash without a workaround label Jun 16, 2017
@tsnouidui
Copy link
Author

This affects all BCVTB users and should ideally be part of the next release.

@Myoldmopar
Copy link
Member

Tempted to close this....

In other words, I'll mark this for the next release, and then in approximately 6 months when I am scanning the final list for 9.4 I'll see this note and probably just say the same thing.

@nealkruis
Copy link
Member

@Myoldmopar I'll take this on for the next release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Defect Includes code to repair a defect in EnergyPlus SeverityHigh This defect is high severity, generally indicating a hard crash without a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants