-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace JSONKit with NSJSONSerialization #106
Comments
We could if we don't mind giving up the performance boost. JSONKit also happens to be very lightweight. Are there any other motivations to remove it? |
The motivation was general code cleaning. I thought if there is a way to serialize/deserialize JSON using iOS native classes, we could migrate to use that instead of relying on a third-party library. On the performance boost, I'll do some benchmarks on an iPad with a couple surveys from the NUBIC NCS project and compare JSONKit versus NSJSONSerialization. In the JSONKit performance tests, he says he ran these on a MacBook Pro with a 2.66GHz Core 2 with iOS 5.1 (I'm assuming), so there may have been optimizations done for the iPad or updates with iOS 6.0 since then. Also, it's worth mentioning that these de-serializations only happen once when survey is initially loaded, for what it's worth. |
Did you get any results you care to share? :) |
results would be interesting. 👍 |
JSON serialization/de-serialization was added to the native iOS libraries back in iOS 5.0 via NSJSONSerialization.
Can we replace JSONKit with NSJSONSerialization?
The text was updated successfully, but these errors were encountered: