-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Wordpress integration #1
Comments
Hey Joe. I'm not sure how we go about getting Knight Lab added to the list. Do we just submit a pull request adding our URL to that file? |
I thought maybe, but looks like not. From the homepage of the Wordpress git repo:
If you want to look into the right process for doing that, you're welcome to! Assign this issue to yourself if you do (if you can?) |
Oh! I guess I assumed that you were assigning it to me. Actually, I'd probably prefer if you or someone else did this one haha. |
I submitted a Trac ticket https://core.trac.wordpress.org/ticket/36301 we'll see if they take it. |
We are supposed to answer all the questions at https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers Odds are not great that we'll persuade them. It may be that we should simply write a wordpress plugin which registers our own oembed providers. It would be a super simple plugin to write, given what we've learned from the more elaborate Timeline/WP plugin. |
this isn't really an issue with this server, but this seems like the easiest place to document things.
We can add ourselves to the Wordpress whitelist here:
https://github.com/WordPress/WordPress/blob/master/wp-includes/class-oembed.php
this will solve the discovery problems for TimelineJS and Juxtapose.
The text was updated successfully, but these errors were encountered: