Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change T4Rec library to expect scalar features to be 1D ibrary to expect scalar features and /list feature to be a dict instead of tuple #820

Closed
viswa-nvidia opened this issue Feb 15, 2023 · 2 comments
Assignees
Milestone

Comments

@viswa-nvidia
Copy link

No description provided.

@gabrielspmoreira gabrielspmoreira changed the title Change T4Rec library to expect scalar features to be 1D Change T4Rec library to expect scalar features to be 1D ibrary to expect scalar features and /list feature to be a dict instead of tuple Feb 23, 2023
@viswa-nvidia viswa-nvidia added this to the Merlin 23.03 milestone Feb 28, 2023
@viswa-nvidia
Copy link
Author

@gabrielspmoreira , comment and close this ticket

@gabrielspmoreira
Copy link
Member

I am closing this ticket because Transformers4Rec was not affect by dataloader changes because:

  • T4Rec sets sparse_as_dense=True for dataloader so that it returns a 2D dense padded dense tensor and not a ragged representation.
  • T4Rec was already automatically squeezing the last dim of scalar input features, which were previously 2D. Now they are 1D, but that doesn't cause an error on squeeze as it does in TF

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants