Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] 04_portfolio_trade.ipynb - Number of filtered stocks differs from text #23

Closed
miguelusque opened this issue Aug 9, 2019 · 1 comment
Closed

[BUG] 04_portfolio_trade.ipynb - Number of filtered stocks differs from text #23

miguelusque opened this issue Aug 9, 2019 · 1 comment
Assignees
@miguelusque
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@miguelusque
Copy link
Contributor

miguelusque commented Aug 9, 2019 •
edited
Loading

Hi,

In 04_portfolio_trade.ipynb sample notebook, it seems that the number of filtered stocks in strategy_cached (#1558), differs from what it is stated in the paragraph below (#4598).

image

I think the text figure should be changed to match the computation.

Regards,
Miguel
@miguelusque miguelusque self-assigned this Aug 9, 2019
@miguelusque miguelusque added bug Something isn't working good first issue Good for newcomers labels Aug 9, 2019
@yidong72
Copy link
Collaborator

this was addressed in the workflow class PR

@avolkov1 avolkov1 mentioned this issue Jul 10, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@miguelusque miguelusque

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelusque @yidong72