Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TASK] Benchmark existing timestamp functions that work in non-UTC time zone (non-DST) #10142

Closed
8 tasks
NVnavkumar opened this issue Jan 2, 2024 · 0 comments · Fixed by #10260
Closed
8 tasks
Assignees
Labels
performance A performance related task/issue

Comments

@NVnavkumar
Copy link
Collaborator

NVnavkumar commented Jan 2, 2024

Now that:

#9802
#6834
#9801
#9815
#6842

have all been merged, we need to measure performance with a non-UTC timezone to ensure that there are no major performance issues with this new functionality. Here is the list of functions/expressions that have been updated:

  • from_utc_timestamp
  • to_utc_timestamp
  • GpuHour
  • GpuMinute
  • GpuSecond
  • from_unixtime
  • unix_timestamp
  • date_format

We should measure performance for all of these functions. The idea would be to post the results in this issue for reference, and file any follow-up issues to fix performance. See #10100 for an example of performance results and potentially some other approaches, but really choose any approach that can give definitive answers for performance on the GPU.

@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 2, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jan 2, 2024
@sameerz sameerz added performance A performance related task/issue and removed feature request New feature or request labels Jan 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants