Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FEA] Add in decimal support for pmod, remainder and divide #1572

Closed
3 tasks done
revans2 opened this issue Jan 22, 2021 · 2 comments · Fixed by #4794
Closed
3 tasks done

[FEA] Add in decimal support for pmod, remainder and divide #1572

revans2 opened this issue Jan 22, 2021 · 2 comments · Fixed by #4794
Assignees
@nartal1
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Jan 22, 2021 •
edited by nartal1
Loading

Is your feature request related to a problem? Please describe.
This is a follow on issue to #1329 rapidsai/cudf#7132 is not predicted to be done until the 0.19 release of cudf. As such I split these off.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 22, 2021
This was referenced Jan 22, 2021
Closed
Closed
Merged
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 26, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Feb 5, 2021

Divide went in early to cudf. It is not a complete solution because like multiply we cannot support the full range of precision values.

@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 12, 2021
@sameerz
Copy link
Collaborator

sameerz commented Feb 2, 2022

mod / pmod support depends on rapidsai/cudf#10179

@amahussein amahussein assigned amahussein and unassigned amahussein Feb 2, 2022
@nartal1 nartal1 self-assigned this Feb 8, 2022
@nartal1 nartal1 mentioned this issue Feb 16, 2022
Merged
@sameerz sameerz mentioned this issue Apr 22, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nartal1 nartal1

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decimal-128 support for mod and pmod nartal1/spark-rapids
4 participants
@revans2 @sameerz @amahussein @nartal1