Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] SPARK-33723 in 3.2.0+ lets ANSI date parsing to throw exceptions #1865

Closed
revans2 opened this issue Mar 4, 2021 · 2 comments
Closed
Assignees
Labels
audit_3.2.0 bug Something isn't working P1 Nice to have for release

Comments

@revans2
Copy link
Collaborator

revans2 commented Mar 4, 2021

Describe the bug
https://issues.apache.org/jira/browse/SPARK-33723 fixed an issue where casting a string to a date with an invalid format would just return null before, but now throws an exception. We need to make sure that we can match it.

Steps/Code to reproduce bug
This was found while trying to run 3.2.0 tests.

    "23:59:59.333666Z",
    "T21:34:56.333666Z"

are invalid date formats and they started to throw exceptions. This has been "fixed" in the tests, but no tests were added to be sure that we also throw exceptions in those cases.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify audit_3.2.0 labels Mar 4, 2021
@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Apr 6, 2021
@wjxiz1992 wjxiz1992 self-assigned this May 28, 2021
@wjxiz1992
Copy link
Collaborator

I can take this and I also found a similar issue #1941

@HaoYang670
Copy link
Collaborator

Could we close this issue, as PR 3396 has addressed the problem?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
audit_3.2.0 bug Something isn't working P1 Nice to have for release
Projects
None yet
Development

No branches or pull requests

4 participants