Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] dup GpuHashJoin.diff case-folding issue #4593

Closed
pxLi opened this issue Jan 21, 2022 · 0 comments · Fixed by #4594
Closed

[BUG] dup GpuHashJoin.diff case-folding issue #4593

pxLi opened this issue Jan 21, 2022 · 0 comments · Fixed by #4594
Labels
bug Something isn't working

Comments

@pxLi
Copy link
Member

pxLi commented Jan 21, 2022

Describe the bug
#4529
#4585
introduced
GpuhashJoin.diff and GpuHashJoin.diff
case-folding issue for different OSs

which confused local checkout on mac

--- a/scripts/spark2diffs/GpuHashJoin.diff
+++ b/scripts/spark2diffs/GpuHashJoin.diff
@@ -6,9 +6,13 @@
 < object GpuHashJoin {
 ---
 > object GpuHashJoin extends Arm {
-101a102
+72c72
+<       meta: RapidsMeta[_, _],
+---
+>       meta: RapidsMeta[_, _, _],
+99a100
 >
-122c123
+120c121
 < }
 ---
 >
@pxLi pxLi added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 21, 2022
@pxLi pxLi removed the ? - Needs Triage Need team to review and classify label Jan 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant