Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Qualification UI uses single precision floating point #6183

Closed
amahussein opened this issue Aug 1, 2022 · 1 comment · Fixed by #6189
Closed

[BUG] Qualification UI uses single precision floating point #6183

amahussein opened this issue Aug 1, 2022 · 1 comment · Fixed by #6189
Assignees
Labels
bug Something isn't working tools

Comments

@amahussein
Copy link
Collaborator

amahussein commented Aug 1, 2022

Describe the bug

Some field values in the UI may not be identical to the CSV output.

Currently, the Qualification UI intends to display some values in a single precision float point. This is done by truncating as rounding could alter the values which may lead to some items being incorrectly labeled.

The CSV files has two precision points.

Picture1
Picture2

Suggests fix
If the difference in values could cause user's confusion, then we may need to take one of the following actions:

  • revisit the values in UI, changing its precision and making sure it matches the CSV.
  • change the values in the CSV to match the UI
  • The difference is acceptable and no need to take any actions.
@amahussein amahussein added bug Something isn't working ? - Needs Triage Need team to review and classify tools labels Aug 1, 2022
@mattahrens
Copy link
Collaborator

I would recommend revisiting the values in the UI to update its precision to 2 digits for more granular info. This will be valuable as our estimations continue to grow in accuracy over time.

@amahussein amahussein self-assigned this Aug 1, 2022
@amahussein amahussein added this to the July 22 - Aug 5 milestone Aug 1, 2022
@amahussein amahussein removed their assignment Aug 1, 2022
@amahussein amahussein self-assigned this Aug 1, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants