feat: expose the NDK revision used to build the V8 and the Runtime #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version will be used by the V8 Snapshot Webpack plugin in order to build the V8 Snapshot using the same Android NDK version. > The revision could be found in the `source.properties` file from the root NDK folder.
vtrifonov
approved these changes
Oct 9, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The version will be used by the V8 Snapshot Webpack plugin in order to build the V8 Snapshot using the same Android NDK version.
Does your commit message include the wording below to reference a specific issue in this repo?
Related to: NativeScript/nativescript-cli#5049
Does your pull request have [unit tests]
No, it does not contain any business logic.