Fix for extra MetaData duplication and invalid rehydration with Kotlin #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n extensions if more than one method with the same name exists.
rigor789
reviewed
Aug 19, 2020
test-app/build-tools/android-metadata-generator/src/src/com/telerik/metadata/Generator.java
Outdated
Show resolved
Hide resolved
test-app/build-tools/android-metadata-generator/src/src/com/telerik/metadata/Builder.java
Outdated
Show resolved
Hide resolved
|
LGTM @NathanaelA so @rigor789 the "resolved" methods seem to only duplicate data since I can't find any place it is used (may be it was used in the past 🤷♂️ ). That skip I think it's a cli flag but the other skips I believe are methods/properties that are not marked as public (methods/properties that are not marked as private can still be accessed via reflection) |
triniwiz
approved these changes
Aug 19, 2020
This comment was marked as abuse.
This comment was marked as abuse.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for extra MetaData duplication and invalid rehydration with Kotlinn extensions if more than one method with the same name exists.
Description
Kotlin extensions can cause issues with hiding metadata. When upgrading to a later version of the Kotlin core this can easily be triggered.
Commit fixes these
Closes NativeScript/NativeScript#8113
Closes NativeScript/NativeScript#8709