Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: build.gradle & kotlinVersion #1642

Merged
merged 1 commit into from
Oct 16, 2020
Merged

fix: build.gradle & kotlinVersion #1642

merged 1 commit into from
Oct 16, 2020

Conversation

NathanaelA
Copy link
Contributor

Fix for Ticket 781


Not sure if it was broken from a change in Gradle Versions; but the "BeforeEvaluate" function does NOT get called before the setting of the kotlinVersion in the top group. So any external properties set in gradle.properties are NOT set at the point we check for it. Copying the code to the top section in the initialize fixes the issue, additional tests will need to be done to see if we can just remove the beforeEvaluate section without any negative side effects. (So leaving that for now, as worst case is it re-assigns the same value to the same key).

Not sure if it is a change in Gradle Versions; but the "BeforeEvaluate"  function does NOT get called before the setting of the `kotlinVersion` in the top group.  So any external properties set in `gradle.properties` are NOT set at the point we check for it.   Copying the code to the top section in the `initialize` fixes the issue, however more tests will need to be done to see if we can just remove the beforeEvaluate section without any negative side effects.
@cla-bot cla-bot bot added the cla: yes label Oct 13, 2020
@NathanaelA NathanaelA requested a review from rigor789 October 13, 2020 02:46
@dev4s
Copy link
Contributor

dev4s commented Oct 13, 2020

Hi @NathanaelA,
things that I see in the logs:

> Task :app:runSbg
org.json.JSONException: Expected a ',' or '}' at character 120
at org.json.JSONTokener.syntaxError(JSONTokener.java:410)
	at org.json.JSONObject.<init>(JSONObject.java:222)
	at org.json.JSONObject.<init>(JSONObject.java:402)
	at org.nativescript.staticbindinggenerator.Main.traverseDirectory(Main.java:163)
	at org.nativescript.staticbindinggenerator.Main.traverseDirectory(Main.java:193)
	at org.nativescript.staticbindinggenerator.Main.traverseDirectory(Main.java:193)
	at org.nativescript.staticbindinggenerator.Main.traverseDirectory(Main.java:193)
	at org.nativescript.staticbindinggenerator.Main.traverseDirectory(Main.java:193)
	at org.nativescript.staticbindinggenerator.Main.generateJsInputFile(Main.java:68)
	at org.nativescript.staticbindinggenerator.Main.main(Main.java:48)
Detailed log here: /home/travis/build/NativeScript/android-runtime/test-app/build-tools/runSbg.log
> Task :waitForUnitTestResultFile
Waiting for tests to finish...
adb: error: remote object '/data/data/com.tns.testapplication/android_unit_test_results.xml' does not exist
com.tns.testapplication process is running
adb: error: remote object '/data/data/com.tns.testapplication/android_unit_test_results.xml' does not exist
com.tns.testapplication process is running
adb: error: remote object '/data/data/com.tns.testapplication/android_unit_test_results.xml' does not exist
com.tns.testapplication process is running
adb: error: remote object '/data/data/com.tns.testapplication/android_unit_test_results.xml' does not exist
com.tns.testapplication process is running
adb: error: remote object '/data/data/com.tns.testapplication/android_unit_test_results.xml' does not exist
com.tns.testapplication process is running
adb: error: remote object '/data/data/com.tns.testapplication/android_unit_test_results.xml' does not exist
com.tns.testapplication process died or never started!
* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':runTestsAndVerifyResults'.

@NathanaelA

This comment was marked as abuse.

@NathanaelA

This comment was marked as abuse.

@NathanaelA

This comment was marked as abuse.

@NathanaelA NathanaelA merged commit 59bcc08 into master Oct 16, 2020
@NathanaelA NathanaelA deleted the NathanaelA-patch-1 branch October 16, 2020 06:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants