Skip to content

respect abi versions when such are provided in configuration #738

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

Plamen5kov
Copy link
Contributor

problem
previously when abi split is used in the gradle configuration, it's not respected in the resulting apk.

solution
when abi split is provided in the gradle configuration, it's respected when naming the resulting apk files.
example for using split:
in folder <app_name>/app/App_Resources/Android/app.gradle add:

android {  
.....
    splits {
        abi {
            enable true //enables the ABIs split mechanism
            reset() //reset the list of ABIs to be included to an empty string
            include 'armeabi-v7a', 'x86' //what abi to spliy by
            universalApk false //don't include an apk that uses all abis combined
        }
    }
}

The file name convention is:
[project-name]-[build_type]-[abi].apk and the resulting apk file in <app_name>/platforms/android/build/outputs/apk would be: testapp-debug-x86.apk

@Plamen5kov Plamen5kov self-assigned this Mar 31, 2017
@ns-bot
Copy link

ns-bot commented Mar 31, 2017

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Mar 31, 2017

💚

Copy link
Contributor

@petekanev petekanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the output is in the format described.

What do you think about adding the 'splits' closure as a default in the project template, but with the universalApk enabled, so that we still produce one package containing all ABIs?

@etabakov your input is appreciated too

@petekanev
Copy link
Contributor

On a second thought, including ABI split by default for users is a great feature for the following 3.1 release.

@petekanev petekanev added this to the 3.0.0-RC milestone Apr 11, 2017
@petekanev petekanev merged commit 298ddaf into master Apr 11, 2017
@petekanev petekanev deleted the plamen5kov/fix-abi-split branch April 11, 2017 08:14
@petekanev
Copy link
Contributor

cc @pkoleva

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants