Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix include gradle flavor generation #937

Merged
merged 5 commits into from
Mar 5, 2018

Conversation

petekanev
Copy link
Contributor

Address #794 thus allowing the build script to generate productFlavors for plugins whose include.gradle don't have android { productFlavors { } } scope, or the android { } scope.

This will fully allow 3.4.x projects to use plugins with no productFlavors, which will be a requirement (handled by the gradle build script) in 4.x android projects.

@petekanev petekanev requested a review from Plamen5kov February 1, 2018 13:02
@ns-bot
Copy link

ns-bot commented Feb 1, 2018

💚

@miroslavaivanova
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Feb 23, 2018

💔

@ns-bot
Copy link

ns-bot commented Feb 23, 2018

💔

@ns-bot
Copy link

ns-bot commented Feb 23, 2018

💚

@miroslavaivanova
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💚

@miroslavaivanova miroslavaivanova added this to the 3.4.2 milestone Feb 28, 2018
@miroslavaivanova
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Mar 5, 2018

💔

@miroslavaivanova
Copy link
Contributor

run ci

@ns-bot
Copy link

ns-bot commented Mar 5, 2018

💚

@ns-bot
Copy link

ns-bot commented Mar 5, 2018

💚

@petekanev petekanev merged commit 7040468 into release Mar 5, 2018
@petekanev petekanev deleted the pete/fix-include-gradle-flavor-generation branch March 5, 2018 14:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants