Skip to content

Commit 1f2b202

Browse files
committedMar 7, 2023
fix: Remove use of V8InspectorPlatform
A separate V8Platform for the inspector seems to be no longer needed, because now the DefaultPlatform supports scheduling tasks.
1 parent 6da1a6b commit 1f2b202

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed
 

‎test-app/runtime/src/main/cpp/Runtime.cpp

+1-13
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
#ifdef APPLICATION_IN_DEBUG
3636
#include "NetworkDomainCallbackHandlers.h"
3737
#include "JsV8InspectorClient.h"
38-
#include "v8_inspector/src/inspector/v8-inspector-platform.h"
3938
#endif
4039

4140
using namespace v8;
@@ -467,18 +466,7 @@ void Runtime::ClearStartupData(JNIEnv* env, jobject obj) {
467466
}
468467

469468
static void InitializeV8() {
470-
Runtime::platform =
471-
#ifdef APPLICATION_IN_DEBUG
472-
// The default V8 platform isn't Chrome DevTools compatible. The frontend uses the
473-
// Runtime.evaluate protocol command with timeout flag for every execution in the console.
474-
// The default platform doesn't implement executing delayed javascript code from a background
475-
// thread. To avoid implementing a full blown scheduler, we use the default platform with a
476-
// timeout=0 flag.
477-
V8InspectorPlatform::CreateDefaultPlatform();
478-
#else
479-
v8::platform::NewDefaultPlatform().release();
480-
#endif
481-
469+
Runtime::platform = v8::platform::NewDefaultPlatform().release();
482470
V8::InitializePlatform(Runtime::platform);
483471
V8::Initialize();
484472
}

0 commit comments

Comments
 (0)