fix: pull js stack trace from wrapped NativeScriptExceptions (#1774)

rigor789 · web-flow · commit 52b7fa242cb4 · 2023-07-26T15:26:23.000+02:00
diff --git a/test-app/runtime/src/main/java/com/tns/Runtime.java b/test-app/runtime/src/main/java/com/tns/Runtime.java
@@ -283,11 +283,14 @@ private static String getStackTraceOnly(String content) {
     }
 
     public static String getJSStackTrace(Throwable ex) {
-        if (ex instanceof NativeScriptException) {
-            return ((NativeScriptException) ex).getIncomingStackTrace();
-        } else {
-            return null;
+        Throwable cause = ex;
+        while(cause != null) {
+            if(cause instanceof NativeScriptException) {
+                return ((NativeScriptException) cause).getIncomingStackTrace();
+            }
+            cause = cause.getCause();
         }
+        return null;
     }
 
     public static String getStackTraceErrorMessage(Throwable ex) {

Original file line number	Diff line number	Diff line change
`@@ -283,11 +283,14 @@ private static String getStackTraceOnly(String content) {`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`public static String getJSStackTrace(Throwable ex) {`
`286`		`- if (ex instanceof NativeScriptException) {`
`287`		`- return ((NativeScriptException) ex).getIncomingStackTrace();`
`288`		`- } else {`
`289`		`- return null;`
	`286`	`+ Throwable cause = ex;`
	`287`	`+ while(cause != null) {`
	`288`	`+ if(cause instanceof NativeScriptException) {`
	`289`	`+ return ((NativeScriptException) cause).getIncomingStackTrace();`
	`290`	`+ }`
	`291`	`+ cause = cause.getCause();`
`290`	`292`	`}`
	`293`	`+ return null;`
`291`	`294`	`}`
`292`	`295`
`293`	`296`	`public static String getStackTraceErrorMessage(Throwable ex) {`