perf: update old args converter with array marshaling optimizations and use this converter again tempporarily

Author: vmutafov

test-app/runtime/src/main/cpp/CallbackHandlers.cpp

@@ -3,7 +3,8 @@
 #include "Util.h"
 #include "V8GlobalHelpers.h"
 #include "V8StringConstants.h"
-#include "./conversions/JSToJavaConverter.h"
+//#include "./conversions/JSToJavaConverter.h"
+#include "JsArgConverter.h"
 #include "JsArgToArrayConverter.h"
 #include "ArgConverter.h"
 #include "v8-profiler.h"
@@ -102,7 +103,8 @@ bool CallbackHandlers::RegisterInstance(Isolate *isolate, const Local<Object> &j
             instance = env.NewObject(generatedJavaClass, mi.mid);
         } else {
             // resolve arguments before passing them on to the constructor
-            JSToJavaConverter argConverter(isolate, argWrapper.args, mi.signature);
+//            JSToJavaConverter argConverter(isolate, argWrapper.args, mi.signature);
+            JsArgConverter argConverter(argWrapper.args, mi.signature);
             auto ctorArgs = argConverter.ToArgs();
 
             instance = env.NewObjectA(generatedJavaClass, mi.mid, ctorArgs);
@@ -322,14 +324,19 @@ void CallbackHandlers::CallJavaMethod(const Local<Object> &caller, const string
                     methodName.c_str());
     }
 
-    JSToJavaConverter argConverter = (entry != nullptr && entry->isExtensionFunction)
-                                     ? JSToJavaConverter(isolate, args, *sig, entry, caller)
-                                     : JSToJavaConverter(isolate, args, *sig, entry);
+//    JSToJavaConverter argConverter = (entry != nullptr && entry->isExtensionFunction)
+//                                     ? JSToJavaConverter(isolate, args, *sig, entry, caller)
+//                                     : JSToJavaConverter(isolate, args, *sig, entry);
 
-//    if (!argConverter->IsValid()) {
-//        JSToJavaConverter::Error err = argConverter->GetError();
-//        throw NativeScriptException(err.msg);
-//    }
+    JsArgConverter argConverter = (entry != nullptr && entry->isExtensionFunction)
+                                        ? JsArgConverter(caller, args, *sig, entry)
+                                        : JsArgConverter(args, false, *sig, entry);
+
+
+    if (!argConverter.IsValid()) {
+        JsArgConverter::Error err = argConverter.GetError();
+        throw NativeScriptException(err.msg);
+    }
 
     JniLocalRef callerJavaObject;
 

test-app/runtime/src/main/cpp/JsArgConverter.cpp

@@ -506,66 +506,110 @@ bool JsArgConverter::ConvertJavaScriptArray(const Local<Array>& jsArr, int index
 
     JEnv env;
     switch (elementTypePrefix) {
-        case 'Z':
+        case 'Z': {
             arr = env.NewBooleanArray(arrLength);
+            jboolean bools[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jboolean value = jsArr->Get(context, i).ToLocalChecked()->BooleanValue(m_isolate);
-                env.SetBooleanArrayRegion((jbooleanArray) arr, i, 1, &value);
+                bools[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->BooleanValue(m_isolate);
             }
+            env.SetBooleanArrayRegion((jbooleanArray) arr, 0, arrLength, bools);
             break;
-        case 'B':
+        }
+        case 'B': {
             arr = env.NewByteArray(arrLength);
+            jbyte bytes[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jbyte value = jsArr->Get(context, i).ToLocalChecked()->Int32Value(context).ToChecked();
-                env.SetByteArrayRegion((jbyteArray) arr, i, 1, &value);
+                bytes[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->Int32Value(context)
+                        .ToChecked();
             }
+            env.SetByteArrayRegion((jbyteArray) arr, 0, arrLength, bytes);
             break;
-        case 'C':
+        }
+        case 'C': {
             arr = env.NewCharArray(arrLength);
+            jchar chars[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                String::Utf8Value utf8(m_isolate, jsArr->Get(context, i).ToLocalChecked()->ToString(context).ToLocalChecked());
-                JniLocalRef s(env.NewString((jchar*) *utf8, 1));
-                const char* singleChar = env.GetStringUTFChars(s, nullptr);
-                jchar value = *singleChar;
+                String::Utf8Value utf8(m_isolate, jsArr->Get(context, i).ToLocalChecked()->ToString(
+                        context).ToLocalChecked());
+                JniLocalRef s(env.NewString((jchar *) *utf8, 1));
+                const char *singleChar = env.GetStringUTFChars(s, nullptr);
+                chars[i] = *singleChar;
                 env.ReleaseStringUTFChars(s, singleChar);
-                env.SetCharArrayRegion((jcharArray) arr, i, 1, &value);
             }
+            env.SetCharArrayRegion((jcharArray) arr, 0, arrLength, chars);
             break;
-        case 'S':
+        }
+        case 'S': {
             arr = env.NewShortArray(arrLength);
+            jshort shorts[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jshort value = jsArr->Get(context, i).ToLocalChecked()->Int32Value(context).ToChecked();
-                env.SetShortArrayRegion((jshortArray) arr, i, 1, &value);
+                shorts[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->Int32Value(context)
+                        .ToChecked();
             }
+            env.SetShortArrayRegion((jshortArray) arr, 0, arrLength, shorts);
             break;
-        case 'I':
+        }
+        case 'I': {
             arr = env.NewIntArray(arrLength);
+            jint ints[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jint value = jsArr->Get(context, i).ToLocalChecked()->Int32Value(context).ToChecked();
-                env.SetIntArrayRegion((jintArray) arr, i, 1, &value);
+                ints[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->Int32Value(context)
+                        .ToChecked();
             }
+            env.SetIntArrayRegion((jintArray) arr, 0, arrLength, ints);
             break;
-        case 'J':
+        }
+        case 'J': {
             arr = env.NewLongArray(arrLength);
+            jlong longs[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jlong value = jsArr->Get(context, i).ToLocalChecked()->NumberValue(context).ToChecked();
-                env.SetLongArrayRegion((jlongArray) arr, i, 1, &value);
+                longs[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->NumberValue(context)
+                        .ToChecked();
             }
+            env.SetLongArrayRegion((jlongArray) arr, 0, arrLength, longs);
             break;
-        case 'F':
+        }
+        case 'F': {
             arr = env.NewFloatArray(arrLength);
+            jfloat floats[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jfloat value = jsArr->Get(context, i).ToLocalChecked()->NumberValue(context).ToChecked();
-                env.SetFloatArrayRegion((jfloatArray) arr, i, 1, &value);
+                floats[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->NumberValue(context)
+                        .ToChecked();
             }
+            env.SetFloatArrayRegion((jfloatArray) arr, 0, arrLength, floats);
             break;
-        case 'D':
+        }
+        case 'D': {
             arr = env.NewDoubleArray(arrLength);
+            jdouble doubles[arrLength];
             for (jsize i = 0; i < arrLength; i++) {
-                jdouble value = jsArr->Get(context, i).ToLocalChecked()->NumberValue(context).ToChecked();
-                env.SetDoubleArrayRegion((jdoubleArray) arr, i, 1, &value);
+                doubles[i] = jsArr
+                        ->Get(context, i)
+                        .ToLocalChecked()
+                        ->NumberValue(context)
+                        .ToChecked();
             }
+            env.SetDoubleArrayRegion((jdoubleArray) arr, 0, arrLength, doubles);
             break;
+        }
         case 'L':
             strippedClassName = elementType.substr(1, elementType.length() - 2);
             elementClass = env.FindClass(strippedClassName);