Skip to content

Commit cd1d285

Browse files
ptomatoedusperoni
authored andcommitted
fix: Leave context after Runtime::PrepareV8Runtime()
In PrepareV8Runtime() we enter the context but never leave it. This is mostly harmless but fails a DCHECK because when we leave the scope of the Locker, there is not supposed to be an entered context.
1 parent 6cdc705 commit cd1d285

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test-app/runtime/src/main/cpp/Runtime.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ Isolate* Runtime::PrepareV8Runtime(const string& filesPath, const string& native
588588

589589
auto global = context->Global();
590590

591-
context->Enter();
591+
v8::Context::Scope contextScope{context};
592592

593593
m_objectManager->Init(isolate);
594594

0 commit comments

Comments
 (0)