fix: possible infinite loop and memory leak in metadata reader #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previsouly we used
if (childNodeDataId == childNodeData->nextSiblingId) {as a breaking out of the loop.Usually this is fine, as it's generated A->B->C->C. The issue is that in some very specific scenarios the metadata will generate:
A->B->C->B
Which will generate an infinite loop.
Additionally, It's not uncommon to have:
Which would generate:
but since F already exists, then it would leak a
MetadataTreeNode