Skip to content

[Angular 10] Using *ngIf breaks layout order #2249

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
mohammadrafigh opened this issue Sep 13, 2020 · 5 comments
Closed

[Angular 10] Using *ngIf breaks layout order #2249

mohammadrafigh opened this issue Sep 13, 2020 · 5 comments

Comments

@mohammadrafigh
Copy link

Environment

  • CLI: 7.0.7
  • Android Runtime: 7.0.0
  • NativeScript-Angular: 10.1.0
  • Angular: 10.1.0

Describe the bug
Using *ngIf over an element/component breaks layout order unless the element/component is wrapped in another layout.

Screenshot from 2020-09-14 00-11-12

To Reproduce
just try:

<StackLayout>
    <Label text="First label" *ngIf="true"></Label>
    <Label text="Second label"></Label>
</StackLayout>

Expected behavior
First label should be rendered before Second label.

Sample project
https://github.com/mohammadrafigh/dynamic-component-issue

Additional context
I'm not sure if it just happens with StackLayout or not but as a workaround wrapping First label like this fixes the order problem:

<StackLayout>
    <StackLayout>
        <Label text="First label" *ngIf="true"></Label>
    </StackLayout>
    <Label text="Second label"></Label>
</StackLayout>

If it helps, the problem occurred after upgrading to Angular 10.0.0 but since the core module was in "rc" I thought this might be a known issue and would be fixed in final release, So this may be an inconsistency problem with Angular rendering behavior and Nativescript runtime.

@OliverNiebsch
Copy link

This is also a bug with Angular 9, see here: #2176

@ivanthz
Copy link

ivanthz commented Sep 16, 2020

Same problem here. Appeared after upgrade to Angular 10 and NS 7.0.

@NathanWalker
Copy link
Contributor

This issue is now fixed with @NativeScript/angular 10.1.3 published now 👍

@rickwalking
Copy link

Hi @NathanWalker. I'm facing this issue in a large messaging application. I can't update to Angular 10 yet because there are plugins with no NativeScript 7 compatibility. Shouldn't this be the case to have a fix for this issues also available in the @nativescript/angular 9 package?

@edusperoni
Copy link
Collaborator

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants