-
-
Notifications
You must be signed in to change notification settings - Fork 196
Ability to merge ExportOptions.plist from App_Resources and from plugins #4528
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@Fatme, I was looking into implementing this feature, but I'm a bit concerned about merging export options from plugin authors. The values in these options are closely tied to the distribution method, which plugin authors have no way of knowing. Personally, I would want full control over this file, which is why merging from Here are the current available options:
Did you have a particular use case in mind where it would make sense to merge from plugin authors? |
No. Currently we support configuration files like
That's true. It seems to make sense to support these options only from |
It’ll be great to support merging of
ExportOptions.plist
file fromApp_Resources
and from plugins. This way every user will be able to add custom options to this file and NativeScript CLI will merge them with the default options. Also, every plugin author will be able to add such custom options inplatforms/ios
folder of the plugin in case when it is required.Currently NativeScript CLI supports merging of
Info.plist
files from plugins and fromApp_Resources
. As the format ofExportOptions.plist
and Info.plist is the same (the both files are.plist
format), it seems the merging ofExportOptions.plist
should be very similar to the merging ofInfo.plist
files. Here is the code that merges Info.plist files. The mergeInfoPlists function has hardcoded path to the Info.plist file. It seems the common logic of this function can be extracted to a separate function, for examplemergePlistFile
. After that we can call this function forInfo.plist
andExportOptions.plist
:The text was updated successfully, but these errors were encountered: