Skip to content

feat: clean up legacy nsconfig if created for bw compat #5380

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Sep 8, 2020

PR Checklist

What is the current behavior?

What is the new behavior?

Whenever the CLI has to generated a nsconfig.json for backwards compatibility - it's recommended to gitignore the file, however with this change, the file should get auto-delete when the cli exits.

@cla-bot cla-bot bot added the cla: yes label Sep 8, 2020
@rigor789 rigor789 merged commit 233091b into master Sep 8, 2020
@rigor789 rigor789 deleted the feat/cleanup-legacy-config branch September 8, 2020 18:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants