Skip to content

fix(test): exit test command if karma finishes execution #5618

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

the test command does not exit when karma exits with error code 0

What is the new behavior?

cli exits with code 0 when karma finishes it's execution

Fixes #5617.

@cla-bot cla-bot bot added the cla: yes label Jan 17, 2022
@edusperoni
Copy link
Collaborator Author

@rigor789 can this be merged? From my tests, any error code != 0 will throw already, so this line is only reached when karma hasn't errored out

@rigor789
Copy link
Member

rigor789 commented Feb 3, 2022

Sure, just haven't been working on the CLI recently - but I'll merge it and it should get auto-published to @next

@rigor789 rigor789 merged commit 9f73e96 into NativeScript:master Feb 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeScript cli does not stop with Karma with singleRun: true
2 participants