Skip to content

Smaller plugin aar #5644

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2022
Merged

Smaller plugin aar #5644

merged 3 commits into from
Mar 7, 2022

Conversation

farfromrefug
Copy link
Contributor

There were a ton of unecessary data added to each aar. Those data would make apps bigger and slower because they also add sbg metadata

@cla-bot cla-bot bot added the cla: yes label Mar 7, 2022
@rigor789 rigor789 merged commit 9ad80bf into NativeScript:master Mar 7, 2022
@rigor789
Copy link
Member 

WARNING:The option 'android.enableSeparateRClassCompilation' is deprecated.
The current default is 'true'.
It has been removed from the current version of the Android Gradle plugin.
Separate R class compilation has been enabled and can no longer be disabled.

Probably something to keep in mind for the near future...

@farfromrefug
Copy link
Contributor Author

@rigor789 indeed might not be needed with gradle 7.0

@farfromrefug farfromrefug deleted the smaller_plugin_aar branch March 15, 2022 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farfromrefug @rigor789