Skip to content

fix: quote windows command line arguments #5808

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

edusperoni
Copy link
Collaborator

This is a follow up of #5802

PR Checklist

What is the current behavior?

When building on windows, the new shell: true option doesn't escape arguments anymore, meaning that any commands that had spaces in their path would not work. This includes npm/adb/avd paths and app paths (that get passed to gradle via arguments)

What is the new behavior?

We now quote every command to preserve the previous behavior.

@cla-bot cla-bot bot added the cla: yes label Jul 25, 2024
@rigor789 rigor789 merged commit bf9a6cd into main Jul 30, 2024
1 check passed
@rigor789 rigor789 deleted the fix/quote-windows-args branch July 30, 2024 19:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants