This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: add xml loader for elements from external namespaces #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
force-pushed
the
sis0k0/xml-namespace-loader
branch
from
c1ed570 to
d2e97ff
Compare
DimitarTachev
approved these changes
May 16, 2018
xml-namespace-loader.js
Outdated
| .join(";"); | ||
|
|
||
| const json = JSON.stringify(source) | ||
| .replace(/\u2028/g, '\\u2028') |
There was a problem hiding this comment.
I believe a comment will be helpful here.
There was a problem hiding this comment.
Nice suggestion! Added a comment.
manoldonev
suggested changes
May 17, 2018
There was a problem hiding this comment.
Tested this with custom component and the require does not work.
When we had custom components in templates and did the bundle-config manually it looked like:
global.registerModule("custom/MyControl", () => require("./custom/MyControl"));
Now it fails with:
global.registerModule("custom/MyControl", () => require("custom/MyControl"));
Sample app here: https://github.com/manoldonev/blank-test-ts
manoldonev
approved these changes
May 17, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.