Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid clones in AccessControllable #38

Open
mooori opened this issue Nov 4, 2022 · 1 comment
Open

Avoid clones in AccessControllable #38

mooori opened this issue Nov 4, 2022 · 1 comment
Assignees
@mooori

Comments

@mooori
Copy link
Contributor

mooori commented Nov 4, 2022 •
edited
Loading

The migration from near_sdk::collections to near_sdk::store introduced new clones in the AccessControllable plugin. Some of them can be avoided by changing the signatures of internal functions.
@mooori mooori self-assigned this Nov 4, 2022
@mooori mooori mentioned this issue Nov 4, 2022
Merged
@mooori
Copy link
Contributor Author

mooori commented Dec 7, 2022 •
edited
Loading

As pointed out in this comment, more optimisations might be possible by changing signatures of AccessControllable trait methods. As of now, they are frequently using owned types instead of references.

@mooori mooori changed the title Change signatures of internal functions to avoid clones Avoid clones in AccessControllable Dec 7, 2022
@mooori mooori mentioned this issue Dec 7, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mooori mooori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mooori