fix (purchasePlaces, book): fix views to forbid some booking

Nemesix493 · Nemesix493 · commit 7a0ea828de33 · 2023-05-09T23:21:08.000+02:00
to respect the app specifications and closes some issues Resolves OpenClassrooms-Student-Center#2, resolves OpenClassrooms-Student-Center#4, resolves OpenClassrooms-Student-Center#5, resolves OpenClassrooms-Student-Center#6,
diff --git a/server.py b/server.py
@@ -1,7 +1,8 @@
-import json
+import json, datetime
 
 from flask import Flask, render_template, request, redirect, flash, url_for
 
+from utils import string_to_datetime
 
 def loadClubs():
     with open('clubs.json') as c:
@@ -42,7 +43,8 @@ def book(competition, club):
     foundClub = [c for c in clubs if c['name'] == club][0]
     foundCompetition = [c for c in competitions if c['name'] == competition][0]
     if foundClub and foundCompetition:
-        return render_template('booking.html',club=foundClub,competition=foundCompetition)
+        places_maximum = min([12, int(foundCompetition['numberOfPlaces']), int(foundClub['points'])])
+        return render_template('booking.html',club=foundClub,competition=foundCompetition, places_maximum=places_maximum)
     else:
         flash("Something went wrong-please try again")
         return render_template('welcome.html', club=club, competitions=competitions)
@@ -52,9 +54,30 @@ def book(competition, club):
 def purchasePlaces():
     competition = [c for c in competitions if c['name'] == request.form['competition']][0]
     club = [c for c in clubs if c['name'] == request.form['club']][0]
-    placesRequired = int(request.form['places'])
+    places_maximum = min([12, int(competition['numberOfPlaces']), int(club['points'])])
+    try:
+        placesRequired = int(request.form['places'])
+    except:
+        if request.form.get('places') == '' or request.form.get('places') == None:
+            placesRequired = 0
+        else:
+            flash(f'({request.form.get("places")}) is not an allowed value !')
+            return render_template('booking.html', club=club, competition=competition, places_maximum=places_maximum), 403
+    if placesRequired > 12:
+        flash('You can\'t book more than 12 places !')
+        return render_template('booking.html', club=club, competition=competition, places_maximum=places_maximum), 403
+    elif placesRequired > int(competition['numberOfPlaces']):
+        flash(f'You can\'t book more than the total of available places ({competition["numberOfPlaces"]}) !')
+        return render_template('booking.html', club=club, competition=competition, places_maximum=places_maximum), 403
+    elif placesRequired > int(club['points']):
+        flash(f'You can\'t book more than your total of points ({club["points"]}) !')
+        return render_template('booking.html', club=club, competition=competition, places_maximum=places_maximum), 403
+    elif string_to_datetime(competition['date']) < datetime.datetime.now():
+        flash(f'You can\'t book on a past competition !')
+        return render_template('booking.html', club=club, competition=competition, places_maximum=places_maximum), 403
+    club['points'] = int(club['points'])-placesRequired
     competition['numberOfPlaces'] = int(competition['numberOfPlaces'])-placesRequired
-    flash('Great-booking complete!')
+    flash(f'Great-booking complete ({placesRequired} booked) !')
     return render_template('welcome.html', club=club, competitions=competitions)
 
 
diff --git a/templates/booking.html b/templates/booking.html
@@ -6,12 +6,22 @@
 </head>
 <body>
     <h2>{{competition['name']}}</h2>
+    Point available: {{club['points']}}<br/>
     Places available: {{competition['numberOfPlaces']}}
+    {% with messages = get_flashed_messages()%}
+    {% if messages %}
+        <ul>
+       {% for message in messages %}
+            <li>{{message}}</li>
+        {% endfor %}
+       </ul>
+    {% endif%}
     <form action="/purchasePlaces" method="post">
         <input type="hidden" name="club" value="{{club['name']}}">
         <input type="hidden" name="competition" value="{{competition['name']}}">
-        <label for="places">How many places?</label><input type="number" name="places" id=""/>
+        <label for="places">How many places?</label><input type="number" name="places" id="" max="{{places_maximum}}" min="0"/>
         <button type="submit">Book</button>
     </form>
+    {% endwith %}
 </body>
 </html>
diff --git a/utils.py b/utils.py
@@ -0,0 +1,13 @@
+import datetime
+
+
+def string_to_datetime(string: str) -> datetime.datetime:
+    date_time = string.split(' ')
+    date = date_time[0].split('-')
+    time = date_time[1].split(':')
+    return datetime.datetime(
+        *[
+            *[ int(value) for value in date],
+            *[ int(value) for value in time]
+        ]
+    )
