Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Collections.emptyList()使用不当问题 #6

Closed
LiZhouYan opened this issue Feb 10, 2022 · 1 comment · Fixed by #7
Closed

Collections.emptyList()使用不当问题 #6

LiZhouYan opened this issue Feb 10, 2022 · 1 comment · Fixed by #7

Comments

@LiZhouYan
Copy link

代码地址：com/nepxion/discovery/agent/plugin/thread/ThreadPlugin.java:55 会出现问题
image

List<String> basePackages = StringUtil.tokenizeToStringList(baseThreadScanPackages, ThreadConstant.THREAD_SCAN_PACKAGES_DELIMITERS); List<String> customPackages = StringUtil.tokenizeToStringList(threadScanPackages, ThreadConstant.THREAD_SCAN_PACKAGES_DELIMITERS); basePackages.addAll(customPackages);
若是basePackages为emptyList，则后面的不能再用emptyList添加东西了 basePackages.addAll(customPackages);
image
这行可能是一个失误吧，建议删除这行代码。
@zifeihan zifeihan linked a pull request Feb 17, 2022 that will close this issue
Fix incorrect use of Collections.emptyList #7
Merged
@HaojunRen
Copy link
Member

已发布Agent 1.2.0，解决了该问题

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect use of Collections.emptyList Nepxion/DiscoveryAgent
2 participants
@LiZhouYan @HaojunRen