Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Label shepherd PRs so they're searchable #54

Open
parshap opened this issue Sep 8, 2018 · 0 comments
Open

Label shepherd PRs so they're searchable #54

parshap opened this issue Sep 8, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers v3

Comments

@parshap
Copy link
Contributor

parshap commented Sep 8, 2018

I can currently search for PRs opened via Shepherd with a GitHub search string like this: org:nerdwallet is:pr shepherd eslint, but that's somewhat fuzzy and it'd be good to be able to do a more precise search.

My suggestion is to support a search pattern like this: org:nerdwallet label:shepherd-migration shepherd_migration_2018_06_25_eslint_config_rename.

  • Apply a shepherd-migration label to all PRs
  • Generate a unique string that gets put in the body text of the PR

The unique string can be generated off of the "id" of the migration. This string should contain only underscores and not hyphens as GitHub search breaks up hyphenated words into individual words and does allow an exact match (regex for valid strings should be something like /[a-zA-Z0-9_]+/). I would do a string search and replace for anything that doesn't match that regex and replace it with an underscore.

The use case for this is to be able to use the GitHub UI to get a quick idea of what state a certain migration is in and help move PRs that are still open along.

@parshap parshap added good first issue Good for newcomers enhancement New feature or request labels Sep 8, 2018
@aorinevo aorinevo self-assigned this Oct 30, 2024
@aorinevo aorinevo added the v3 label Oct 30, 2024
@aorinevo aorinevo mentioned this issue Nov 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers v3
Projects
None yet
Development

No branches or pull requests

2 participants