Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Parameter transaction is null when TransactionViewModel.Initialize(transaction) is called from MessageBus.Current.Listen<TransactionAdded>() in class TransactionsViewModel #2

Open
mwherman2000 opened this issue Jan 13, 2018 · 3 comments

Comments

@mwherman2000
Copy link

Parameter transaction is null when TransactionViewModel.Initialize(transaction) is called from MessageBus.Current.Listen() in class TransactionsViewModel... Here is a copy of the calling code:

MessageBus.Current.Listen().Subscribe(async x =>
{
if (Util.Utils.IsValidUrl(Url))
{
var web3 = new Web3.Web3(Url);
var transactionViewModel = new TransactionViewModel();
var transaction = await web3.Eth.Transactions.GetTransactionByHash.SendRequestAsync(x.TransactionHash);
transactionViewModel.Initialise(transaction);
transactionViewModel.Status = TransactionViewModel.STATUS_INPROGRESS;
lock (receiptsCheckLock)
{
Transactions.Add(transactionViewModel)
}
}
});

@juanfranblanco
Copy link
Member

In what scenario you see this? There is not much (if any) error handling in the sample. But when a transaction is sent, the transaction hash is put in the bus.

@mwherman2000
Copy link
Author

Sending a plain old transaction on mainnet. I did add something to the extra data field:

badbad

The value/amount was 0.001 and the rest was defaulted.

@juanfranblanco
Copy link
Member

I guess the extra data might have made the transaction to be rejected, and removed from pending before being able to retrieve it. So yes a null check might come handy there.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants