Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add inbound field for admin_peers json-rpc call. #7317

Open
barnabasbusa opened this issue Aug 8, 2024 · 0 comments · May be fixed by #7443
Open

Add inbound field for admin_peers json-rpc call. #7317

barnabasbusa opened this issue Aug 8, 2024 · 0 comments · May be fixed by #7443
Assignees
Labels

Comments

@barnabasbusa
Copy link

barnabasbusa commented Aug 8, 2024

Is your feature request related to a problem? Please describe.
admin_peers json-rpc call seems to not show whether a peer is inbound/outbound on nethermind, while on geth/erigon/ethjs/reth it does. Could we add this extra field for nethermind?

Describe the solution you'd like
Expected output:

"jsonrpc": "2.0",
  "id": 1,
  "result": [
    {
      "enode": "enode://2342d72cace0dca858a7a0739d66665c9b26bd3215f5fd8b683306a28d2eaa9ecc76f215e7625ce97e3e7d8139974c5c0441a7032890ba62aeeb9a7182a412a9@165.227.128.224:39694",
      "id": "091a685e1319bf54dc4f55ec98649a83499acbd462fb4b0a874595ea81541d6a",
      "name": "erigon/v3.00.0-alpha1-da0d58c2/linux-amd64/go1.22.5",
      "caps": [
        "eth/68"
      ],
      "network": {
        "localAddress": "172.18.0.3:30303",
        "remoteAddress": "165.227.128.224:39694",
        "inbound": true,
        "trusted": false,
        "static": false
      },
      "protocols": {
        "eth": {
          "version": 68
        }
      }
    },

Current output:

    {
      "clientId": "Geth/v1.14.8-unstable-37c4b033-20240724/linux-amd64/go1.22.5",
      "host": "164.92.238.47",
      "port": 30303,
      "address": "164.92.238.47:30303",
      "isBootnode": false,
      "isTrusted": false,
      "isStatic": false,
      "enode": "enode://1ae87a905cd8a258a4da5fe7b47348c5b7f02fcbefaab68886bc05f7eb6584ff3d8122e572a864c0e7d72cf8876affe5dc3920a152c3ffe97fe4e2d3cd7b0c69@164.92.238.47:30303"
    },

Would be good to add a field like inbound:<bool>.

@barnabasbusa barnabasbusa changed the title Add inbound field for admin_peers json-rpc call. Add inbound field for admin_peers json-rpc call. Aug 8, 2024
@MarekM25 MarekM25 added the rpc label Aug 29, 2024
@obasekiosa obasekiosa linked a pull request Sep 16, 2024 that will close this issue
16 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants