Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New Account Setup Dialog #128

Closed
bordam opened this issue Dec 8, 2022 · 17 comments · Fixed by #183
Closed

New Account Setup Dialog #128

bordam opened this issue Dec 8, 2022 · 17 comments · Fixed by #183
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone

Comments

@bordam
Copy link
Contributor

bordam commented Dec 8, 2022

I think outcomes are created more often than incomes, so why not either set outcome as default or add an option to choose the default transaction type?

@zothma
Copy link
Contributor

zothma commented Dec 8, 2022

I think it would be quite an interesting idea indeed

@nlogozzo
Copy link
Member

nlogozzo commented Dec 8, 2022

I'm thinking of creating a whole Account Setup dialog when you make a new account. In this dialog will be currency (locale or custom), default transaction (income vs expense), and other customizable options. Of course, this dialog will be able to be accessed at any time from the account view to change settings whenever.

@nlogozzo nlogozzo added the feature New feature or request label Dec 8, 2022
@fsobolev
Copy link
Member

fsobolev commented Dec 9, 2022

I'm thinking of creating a whole Account Setup dialog when you make a new account.

A mockup (made in Python, will rewrite in C# when the app will be ported).


EDIT: I totally forgot about requested feature to set account as personal or business. It will be added of course, just one more ComboRow at the bottom with the title "Account type" and the subtitle "This is only a useful label that doesn't affect how the app works".

@nlogozzo nlogozzo added this to the V2023.1.0 milestone Dec 27, 2022
@nlogozzo nlogozzo changed the title Ability to set default transaction type New Account Setup Dialog Dec 27, 2022
@vanillajonathan
Copy link
Contributor

The country flag emojis could be used for accounts in different countries.

Example:

  • 🇺🇸 My American account
  • 🇨🇭 My Swiss account

See #118

@fsobolev
Copy link
Member

The country flag emojis could be used for accounts in different countries.

Example:

  • 🇺🇸 My American account
  • 🇨🇭 My Swiss account

See #118

#120 (reply in thread)

Well you will be able to add any emoji wherever you want in account name

Users who don't have accounts in multiple jurisdictions, or who don't use multiple currencies, or who track money not from real world, don't need this, so this feature is redundant.

@vanillajonathan
Copy link
Contributor

Users who don't have accounts in multiple jurisdictions, or who don't use multiple currencies, or who track money not from real world, don't need this, so this feature is redundant.

Well it could be an optional feature that those people don't have to use. It could also include icons for crypto currencies maybe.

@nlogozzo
Copy link
Member

nlogozzo commented Jan 7, 2023

image

Major developments on account-setup-dialog branch. GNOME dialog is coming soon :)

Feel free to play around with it BUT DO NOT USE IMPORTANT .nmoney FILES as the API is unstable and could break/corrupt something

@nlogozzo
Copy link
Member

nlogozzo commented Jan 7, 2023

image

Courtesy of @fsobolev :)

@vanillajonathan
Copy link
Contributor

And if you don't use a custom currency, so you use your system reported currency, then you change your system settings, what happens then?
Does the currency for the account change to the new system settings?

I think it would be better to avoid the the term "custom currency", remove the "Use Custom Currency" switch, and always require the user to specify a currency, however that currency can be set by the default to the system reported currency.

@bordam
Copy link
Contributor Author

bordam commented Jan 7, 2023

And if you don't use a custom currency, so you use your system reported currency, then you change your system settings, what happens then? Does the currency for the account change to the new system settings?

I think it would be better to avoid the the term "custom currency", remove the "Use Custom Currency" switch, and always require the user to specify a currency, however that currency can be set by the default to the system reported currency.

AFAIU once the currency is set for an account it’s not affected by system locale at all

@vanillajonathan
Copy link
Contributor

AFAIU once the currency is set for an account it’s not affected by system locale at all

Good, it shouldn't, but it isn't clear, hence why I think it would be better to remove any ambiguity by removing the Use Custom Currency switch.

@nlogozzo
Copy link
Member

nlogozzo commented Jan 7, 2023

The Use Custom Currency feature as shown allows a user to change their currency symbol for the account. For example, if my system reports $ and I want to use i can change that here.

However, Money still uses the system locale to determine the number formating used. For example, if i change my currency symbol to , but I'm in the USA, my nunbers will be €1,000.00. Whereas if I'm in France and I change ny symbol to $, my numbers will be 1.000,00 $

@nlogozzo
Copy link
Member

nlogozzo commented Jan 7, 2023

If Use Custom Currency is off, the account will use the symbol from the current locale just as before, and any changes to system locale will be seen in the account, just as before.

@fsobolev
Copy link
Member

fsobolev commented Jan 7, 2023

AFAIU once the currency is set for an account it’s not affected by system locale at all

Good, it shouldn't, but it isn't clear, hence why I think it would be better to remove any ambiguity by removing the Use Custom Currency switch.

It's not like people usually change locale after OS is installed, so I don't think most of users will even care about what will happen if locale is changed - but if they will care, they will find out, without any destructive changes, that the app tries to get currency and numbers format from locale every time it starts. And if a user wants to use something different than a system currency, only then they will need to do extra actions to change currency to whatever cryptodabloons they want.
And anyway, even without experiments with system locale, users will be able to know how everything works in the app by reading documentation (that I will add soon).

@nlogozzo
Copy link
Member

nlogozzo commented Jan 7, 2023

The country flag emojis could be used for accounts in different countries.

Example:

  • 🇺🇸 My American account
  • 🇨🇭 My Swiss account

See #118

image

Emojis are fully supported in the AccountName on GNOME and WinUI for this :)

@nlogozzo
Copy link
Member

nlogozzo commented Jan 7, 2023

Although toggles are not shown in the dialog, Money will remember Show Groups and Sort First To Last toggle setting on an individual account basis now.

@nlogozzo nlogozzo unpinned this issue Jan 7, 2023
@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Jan 10, 2023
@nlogozzo
Copy link
Member

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants