Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QIF import broken #368

Closed
ascpial opened this issue Mar 14, 2023 · 13 comments · Fixed by #371
Closed

QIF import broken #368

ascpial opened this issue Mar 14, 2023 · 13 comments · Fixed by #371
Labels
bug Something isn't working in-beta This issue is fixed in a beta version
Milestone

Comments

@ascpial
Copy link

ascpial commented Mar 14, 2023

I tried to import data from an other app, HomeBank, as well as the example file given in #265 and the toaster says "0 transactions imported".

The format of the date in both files is correct (US date: MM/DD/YYYY).

I'm using the latest version at the time of writing, which is 2023.2.2.

A QIF file that is broken: test.zip

@nlogozzo nlogozzo added the bug Something isn't working label Mar 14, 2023
@nlogozzo nlogozzo added this to the V2023.3.0 milestone Mar 14, 2023
@nlogozzo
Copy link
Member

Recording.2023-03-14.123115.mp4

I can't reproduce it...works fine for me.

@nlogozzo
Copy link
Member

^ That's running V2023.3.0-beta1, but that release did not change QIF from the latest stable.

@ascpial
Copy link
Author

ascpial commented Mar 14, 2023

Sorry but everything is in french:

Capture.video.du.2023-03-14.17-46-34.webm

There is nothing in the list after restarting.

@nlogozzo
Copy link
Member

It worked fine for me using GNOME version too.
Maybe it's because the application is in French.
If you run the app using en-US does it work?

@ascpial
Copy link
Author

ascpial commented Mar 14, 2023

I tried in english, and it works fine, so the issue might come from language translation.

@nlogozzo
Copy link
Member

I have to see what localization occurs for QIF...and i'll fix it.

@nlogozzo
Copy link
Member

I believe this line is the problem: https://github.com/nlogozzo/NickvisionMoney/blob/main/NickvisionMoney.Shared/Models/Account.cs#L1354

I believe the en_US culture needs to be passed to that DateTime function other wise it will try to parse the date with the current locale instead of en_US.

I'm not home right now so I can't make the change and test. Maybe @fsobolev can.

@fsobolev
Copy link
Member

I'm not home right now so I can't make the change and test. Maybe @fsobolev can.

I will work on it.

@ascpial
Copy link
Author

ascpial commented Mar 15, 2023

I quickly tested the fix with the CI build and it's working great, thanks for the support!

@nlogozzo
Copy link
Member

Once #355 is merged, I'll release beta 2 with all the file fixes :)

@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Mar 16, 2023
@nlogozzo
Copy link
Member

@kivutar
Copy link

kivutar commented Apr 27, 2023

Using 2023.4.1 from flathub I'm also having issues importing a QIF with date format DD/MM/YYYY.

If I change the dates in the QIF, Denaro is able to import the file properly.

@nlogozzo
Copy link
Member

@kivutar As per docs: https://htmlpreview.github.io/?https://raw.githubusercontent.com/NickvisionApps/Denaro/2023.4.1/NickvisionMoney.Shared/Docs/html/C/import-export.html

Quicken Interchange Format (.qif)
Dates should be in English (US) format (MM/DD/YYYY).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working in-beta This issue is fixed in a beta version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants