Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement https://github.com/mailcheck/mailcheck #23

Closed
Nightapes opened this issue Feb 24, 2017 · 4 comments · Fixed by #65
Closed

Implement https://github.com/mailcheck/mailcheck #23

Nightapes opened this issue Feb 24, 2017 · 4 comments · Fixed by #65

Comments

@Nightapes
Copy link
Owner

No description provided.

@adyba
Copy link

adyba commented Mar 8, 2017

Both email validators are happy with name@domain even without TLD.
It could be do done via standard Validators.pattern(/^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/) or even more sophisticated RedEx.
(this one will not accept today's fancy nTLD's like .mobi, .guru, .club etc. )

@Nightapes
Copy link
Owner Author

The normal validator uses the HTML5 validation regex. The email name@domain is a valid email (used sometimes in companies).
What i like from the mailcheck is that it offers corrections for false TLD's. Like:
diagram

But i'm unsure if the validator should return the correct value as a proposal or a extra pipe.

@jcphlux
Copy link

jcphlux commented Jun 24, 2017

I think this is a very cool idea. No clue how to make it work but vert cool.

@Nightapes
Copy link
Owner Author

🎉 This issue has been resolved in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants