kernel panic - usbhid.ko not found - T430, v2.5.0

[marmarek]

Please identify some basic details to help process the report

A. Provide Hardware Details

1. What board are you using (see list of boards here)?

2. Does your computer have a dGPU or is it iGPU-only?

• dGPU
• iGPU-only

3. Who installed Heads on this computer?

• Insurgo
• Nitrokey
• Purism
• Other provider
• Self-installed

4. What PGP key is being used?

• Librem Key
• Nitrokey Pro 2
• Nitrokey Storage
• Yubikey
• Other

5. Are you using the PGP key to provide HOTP verification?

• Yes
• No
• I don't know

B. Identify how the board was flashed

1. Is this problem related to updating heads or flashing it for the first time?

• First-time flash
• Updating heads

2. If the problem is related to an update, how did you attempt to apply the update?

• Using the Heads GUI
• Flashrom via the Recovery Shell
• External flashing

3. How was Heads initially flashed

• External flashing
• Internal-only / 1vyrain
• Don't know

4. Was the board flashed with a maximized or non-maximized/legacy rom?

• Maximized
• Non-maximized / legacy
• I don't know

5. If Heads was externally flashed, was IFD unlocked?

• Yes
• No
• Don't know

C. Identify the rom related to this bug report

1. Did you download or build the rom at issue in this bug report?

• I downloaded it
• I built it

2. If you downloaded your rom, where did you get it from?

• Heads CircleCi
• Purism
• Nitrokey
• Somewhere else (please identify)

Please provide the release number or otherwise identify the rom downloaded
https://github.com/Nitrokey/heads/releases/download/v2.5.0/firmware-nitropad-t430-maximized-v2.5.0.zip

3. If you built your rom, which repository:branch did you use?

• Heads:Master
• Other (please identify)

4. What version of coreboot did you use in building?

• 4.8.1 (current default in heads:master)
• 4.13
• 4.14
• 4.15
• Other (please specify)
• I don't know

5. In building the rom where did you get the blobs?

• No blobs required
• Provided by the company that installed Heads on the device
• Extracted from a backup rom taken from this device
• Extracted from another backup rom taken from another device (please identify the board model)
• Extracted from the online bios using the automated tools provided in Heads
• I don't know

Please describe the problem

Describe the bug

After updating Heads firmware to latest Nitrokey v2.5.0, the system panics on boot

To Reproduce
Steps to reproduce the behavior:

1. Update (downgrade?) from heads-t430-hotp-maximized-v0.2.0-2407-gb36ed46.zip
2. Reboot
3. Observe panic

Expected behavior
Normal boot, USB keyboard enabled.

Screenshots

Additional context

I do use USB keyboard there, so it was enabled in the options menu before.

[nestire]

mm I can not reproduce this with a fresh install. But the 2.5.0 version does not support usb keyboards, my guess is that the update copied the config that enables that, so the loading of usbhid.ko is triggered and that fails then since it is not included in this build.

[marmarek]

This is indeed very likely cause. Is there a version with USB keyboard support? Upstream version nowadays has it opt-in via settings menu.

[tlaurion]

This is indeed very likely cause. Is there a version with USB keyboard support? Upstream version nowadays has it opt-in via settings menu.

Would need a +1 release downstream. Usb hid should be built as module per Linux config, and included in modules.cpio per board config, packed under initrd where init should load it if configured with usb optional keyboard per config settings, as for all other boards nowadays following your testing needs @marmarek, just like it was done for x230.

If not it's a bug, or your testing need requiring usb keyboard support per initial external flashing, then a usbkb board variant should be provided per nitrokey/upstream, just like a usbkb variant for x230 still exists upstream https://github.com/linuxboot/heads/blob/462c157b23d4e45b80a7685d289f9a6d14d53fdd/boards/x230-hotp-maximized_usb-kb/x230-hotp-maximized_usb-kb.config#L24

To be tested from upstream Circleci builds for t430 and for new versioning downstream as nitropad rebranding for your testing use case.

If you look at nitrokey fork, it's based on master +1 rebranding commit.

[nestire]

have a look here https://github.com/Nitrokey/heads/tree/nitropad-v2.6.0 . circle ci fails there at the moment since some server is down but in general this should work

[marmarek]

git.savannah.gnu.org seems to be back, hopefully the build will work now :)

[marmarek]

I can confirm the new build has the issue fixed.