From 17951a772d12dd108f68b768be111954e8d8e7c8 Mon Sep 17 00:00:00 2001 From: Olivier Sprangers Date: Thu, 12 Dec 2024 18:26:10 +0100 Subject: [PATCH] comments_jose --- hierarchicalforecast/evaluation.py | 4 ++-- nbs/src/evaluation.ipynb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hierarchicalforecast/evaluation.py b/hierarchicalforecast/evaluation.py index a387032..6200382 100644 --- a/hierarchicalforecast/evaluation.py +++ b/hierarchicalforecast/evaluation.py @@ -495,11 +495,11 @@ def evaluate( # %% ../nbs/src/evaluation.ipynb 20 def evaluate( - df: Frame, + df: FrameT, metrics: list[Callable], tags: dict[str, np.ndarray], models: Optional[list[str]] = None, - train_df: Optional[Frame] = None, + train_df: Optional[FrameT] = None, level: Optional[list[int]] = None, id_col: str = "unique_id", time_col: str = "ds", diff --git a/nbs/src/evaluation.ipynb b/nbs/src/evaluation.ipynb index ae2d9b6..2ab38dd 100644 --- a/nbs/src/evaluation.ipynb +++ b/nbs/src/evaluation.ipynb @@ -609,11 +609,11 @@ "source": [ "#| exporti\n", "def evaluate(\n", - " df: Frame,\n", + " df: FrameT,\n", " metrics: list[Callable],\n", " tags: dict[str, np.ndarray],\n", " models: Optional[list[str]] = None,\n", - " train_df: Optional[Frame] = None,\n", + " train_df: Optional[FrameT] = None,\n", " level: Optional[list[int]] = None,\n", " id_col: str = \"unique_id\",\n", " time_col: str = \"ds\",\n",